tari-project / tari / 15484013348
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 687
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 72.04% (+0.3%) from 71.789%
15484013348

push

github

web-flow 
fix(network-discovery): add back idle event handling (#7194)

Description
---
fix(network-discovery): add back idle event handling

Motivation and Context
---
network discovery was spinning at full speed because the Idle event
transition was removed. Network logs would rotate < 1s.

```
[comms::dht::network_discovery::ready] [Thread:123190302967360] DEBUG NetworkDiscovery::Ready: Peer list contains 759 entries. Current discovery rounds in this cycle: 0.
[comms::dht::network_discovery::ready] [Thread:123190302967360] DEBUG First active round (current_num_rounds = 0) and num_peers (759) >= min_desired_peers (16). Forcing DHT discovery.
 [comms::dht::network_discovery::ready] [Thread:123190302967360] DEBUG Selecting 5 random peers for discovery (last round info available: false, new peers in last round: false).
[comms::dht::network_discovery::ready] [Thread:123190302967360] DEBUG No suitable peers found for the forced DHT discovery round (current_num_rounds = 0 path). Transitioning to Idle.
 [comms::dht::network_discovery] [Thread:123190302967360] DEBUG Transition triggered from current state `Ready` by event `Idle`
comms::dht::network_discovery] [Thread:123190302967360] DEBUG No state transition for event `Idle`. The current state is `Ready`

...instant rinse and repeat...
```

This PR adds the idle state transition back. Note that idle will idle
for 30 minutes so should only transition when all work is done and we
have downloaded sufficient peers.

How Has This Been Tested?
---
Manually - console wallet with empty peer db

What process can a PR reviewer use to test or verify this change?
---

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other... (continued)

3 of 4 new or added lines in 2 files covered. (75.0%)

412 existing lines in 30 files now uncovered.

80882 of 112274 relevant lines covered (72.04%)

242938.65 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
32.29
 -0.11% comms/dht/src/network_discovery/state_machine.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
47.17
 -0.94% base_layer/core/src/base_node/proto/response.rs
1
22.35
 -1.18% base_layer/core/src/chain_storage/error.rs
1
88.48
 0.0% base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
1
82.61
 5.8% base_layer/core/src/consensus/chain_strength_comparer.rs
1
58.54
 -0.81% base_layer/core/src/mempool/service/inbound_handlers.rs
1
58.27
 1.57% base_layer/core/src/mempool/service/service.rs
1
93.36
 -0.17% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
90.12
 -0.25% base_layer/core/src/validation/aggregate_body/aggregate_body_internal_validator.rs
1
73.98
 -0.08% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
1
85.52
 -0.04% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
1
32.29
 -0.11% comms/dht/src/network_discovery/state_machine.rs
3
88.71
 -4.84% base_layer/common_types/src/types/fixed_hash.rs
3
65.06
 -0.4% comms/dht/src/connectivity/mod.rs
4
61.9
 -9.52% base_layer/core/src/base_node/chain_metadata_service/handle.rs
4
20.63
 -1.79% base_layer/core/src/base_node/comms_interface/local_interface.rs
4
46.01
 -2.45% base_layer/core/src/chain_storage/async_db.rs
4
63.41
 10.86% base_layer/core/src/chain_storage/blockchain_database.rs
4
68.84
 4.76% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
5
19.05
 -23.81% base_layer/core/src/base_node/comms_interface/error.rs
5
53.96
 -0.36% base_layer/core/src/chain_storage/db_transaction.rs
7
74.4
 -5.6% base_layer/core/src/base_node/sync/sync_peer.rs
8
31.25
 -16.67% base_layer/core/src/base_node/sync/hooks.rs
10
79.41
 2.09% base_layer/core/src/test_helpers/blockchain.rs
10
63.1
 -5.95% base_layer/wallet/src/transaction_service/tasks/send_finalized_transaction.rs
12
51.12
 -1.59% base_layer/core/src/base_node/comms_interface/inbound_handlers.rs
12
80.08
 -4.69% base_layer/core/src/base_node/sync/header_sync/validator.rs
15
55.2
 -12.0% base_layer/core/src/base_node/metrics.rs
23
57.48
 -18.11% base_layer/core/src/base_node/state_machine_service/states/header_sync.rs
29
27.71
 8.43% base_layer/core/src/base_node/sync/rpc/service.rs
239
13.92
 -38.67% base_layer/core/src/base_node/sync/header_sync/synchronizer.rs
Jobs
ID Job ID Ran Files Coverage
1 15484013348.1 687
72.04
 GitHub Action Run
Source Files on build 15484013348