bolshakov / stoplight / 15487024400

100%

push

github

Simplify Light class structure and improve documentation (#337)

* Refactor: Remove Runnable module and flatten strategy class hierarchy

- Move `state`, `color`, and `run` methods from Runnable module directly into Light class
- Relocate strategy classes from `Stoplight::Light::Runnable::*` to `Stoplight::Light::*`
- Update all specs to reflect new class hierarchy
- Consolidate shared examples and move runnable specs into main light_spec.rb

This simplifies the codebase by eliminating an unnecessary abstraction layer
while maintaining the same functionality and behavior.

* Refactor: Remove Lockable module and move lock/unlock methods to Light class

- Move `lock` and `unlock` methods from Lockable module directly into Light class
- Remove `include Lockable` from Light class
- Delete separate lockable_spec.rb and move tests into main light_spec.rb

This continues the simplification effort by eliminating another unnecessary
abstraction layer while maintaining the same locking functionality.

* Refactor: Extract builder-style methods into ConfigurationBuilderInterface module

- Rename `Configurable` to `ConfigurationBuilderInterface` to better reflect its purpose
- Move core configuration methods (`with`, `name`, `reconfigure`) from module to Light class
- Keep builder-style methods (`with_data_store`, `with_threshold`, etc.) in the interface module
- Enhance documentation with additional usage examples in main Stoplight() method

This separation clarifies the distinction between core configuration functionality
and the optional builder-style configuration interface.

* Improve README clarity and consistency

- Fix window size default description from "infinity" to "nil" with clearer explanation
- Update all code examples to use consistent double-quote strings
- Use human readable service names in examples ("Payment Service" vs "payment-service")
- Fix Redis configuration examples
- Remove "Builder Style" section to simplify configuration guidance and ... (continued)

107 of 107 new or added lines in 6 files covered. (100.0%)

1035 of 1037 relevant lines covered (99.81%)

792.41 hits per line