zooniverse / Panoptes-Front-End / 15477933166

56%

Build Type

push

github

Committed by web-flow

Commit Message

Rubin 2025 Landing Page pt2: fix UI/UX bugs (#7314)

* RubinPage: pass user object to sign in & register forms. Remove subpaths.

* RubinPage: use tabs to separate forms

* RubinPage: set basic onSuccess callbacks for SignIn and Register forms

* RubinPage: fix tests

* RubinPage: add Already Signed In message. Update .styl and en.json

* RubinPage: add 'onSuccess' message component

* SignInForm: remove onSuccess callbacks when clicking Forgot Password. Why was this there?

* SignInForm: refactor wonky decaffeinated code

* SignInForm: fix broken onSuccess() callback that wasn't triggering

* RubinPage: redirect to home page on successful sign in or register

* Cleanup

* Cleanup: remove Geordi

* SignInForm: re-code error handling components. Make code easier to read

* SignInPage: fix weird non-value of login and password. Rewrite code to be easier to read.

* RegisterForm: remove Geordi

* SignInPage: restyle

* RegisterForm: fix onSuccess and onFailure callbacks

* RegisterForm: cleanup submit functions

* SignInForm: minor code improvements

* RegisterForm: code cleanup

* RegisterForm: rewrite login input

* RegisterForm: handleSubmit() no longer uses React refs

* RegisterForm: change email, password, confirmedPassword to use handleUserInput()

* RegisterForm: change okayToEmail, betaTester to use handleUserInput()

* RubinPage: re-add /sign-in and /register subpaths

* RubinPage: set register as the default tab

* RubinPage: don't redirect after sign in or register. Improve Already Signed In message

* RubinPage: fix tests

* RubinPage: ensure Success Message only shows if there's a logged-in user

Co-authored-by: Mark Bouslog <mark@zooniverse.org>

* SignInForm: fix incorrect translation string

Co-authored-by: Mark Bouslog <mark@zooniverse.org>

---------

Co-authored-by: Mark Bouslog <mark@zooniverse.org>

Run Details

6890 of 12615 branches covered (54.62%)

Branch coverage included in aggregate %.

8 of 67 new or added lines in 3 files covered. (11.94%)

1 existing line in 1 file now uncovered.

8239 of 14242 relevant lines covered (57.85%)

101.47 hits per line