NVIDIA / nvidia-container-toolkit / 15468836289

34%

main: 39%

Build Type

push

github

Committed by ArangoGutierrez

Commit Message

BUGFIX: modifier: respect GPU volume-mount device requests

The gated modifiers used to add support for GDS, Mofed, and CUDA Forward Comatibility only check the NVIDIA_VISIBLE_DEVICES envvar to determine whether GPUs are requested and modifications should be made. This means that use cases where volume mounts are used to request devices (e.g. when using the GPU Device Plugin) are not supported.

This patch takes visibleDevicesFromEnvVar private, making VisibleDevices the only exported method to query valid devices.
And edits the gated modifiers to use this func, ensuring device requests
via mounts are also taken into acount.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Run Details

11 of 15 new or added lines in 5 files covered. (73.33%)

9 existing lines in 1 file now uncovered.

4316 of 12730 relevant lines covered (33.9%)

0.38 hits per line