15464329468
100%
master: 100%

Ran 05 Jun 2025 10:15AM UTC

Jobs 3

Files 57

Run time 4min

Badge

Embed ▾

Committed 05 Jun 2025 10:08AM UTC coverage: 99.855%. Remained the same

Build # 15464329468

Build Type

push

github

Committed by

CyberDem0n

Commit Message

Check that synchronous_standby_names contains expected value (#3370)

* Change interface of SyncHandler.current_state()

Make it always return nodes from synchronous_standby_names and
sync_confirmed instead of numsync_confirmed.

* Check that synchronous_standby_names contains expected value

Current mechanism implementing state machine for non-quorum synchronous
replication didn't check actual value of synchronous_standby_names, what
resulted in stale value of synchronous_standby_names being used when
pg_stat_replication is a subset of synchronous_standby_names.

Such situation is mainly possible when standby nodes with replicatefrom
tag connect to the primary because cascading replicas are temporary not
accessible.

To prevent it from happening we implement following measures:
1. Check the actual value of synchronous_standby_names when deceding
   whether we should continue to run state machine
2. Take into account `replicatefrom` tag on nodes that are streaming
   from the primary and don't consider them to be synchronous candidates
   if some other node in a chain already streaming from the primary.

Close https://github.com/patroni/patroni/issues/3369

Coverage Stats

14495 of 14516 relevant lines covered (99.86%)

2.98 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	unit-macos - 15464329468.1	05 Jun 2025 10:32AM UTC	57	99.78	GitHub Action Run
2	unit-windows - 15464329468.2	05 Jun 2025 10:32AM UTC	57	98.83
3	unit-ubuntu - 15464329468.3	05 Jun 2025 10:32AM UTC	57	99.86

patroni / patroni / 15464329468
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 15464329468

patroni / patroni / 15464329468 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 15464329468

patroni / patroni / 15464329468
100%
master: 100%

README BADGES
x