rust-bitcoin / rust-bitcoin / 15449682371
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 130
Run time 5min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.347%. Remained the same
15449682371

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#4568: Remove conversion impl macro for `Magic`/`Network`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/028a0d6558129f554de8c4247481bc0ad80f1c27">028a0d655 Remove conversion impl macro for `Magic`/`Network` (rustaceanrob)

Pull request description:

  Closes #4560 (or at least one way to close it)

  Handle the coversion of new networks directly in the `From` and `TryFrom` implementations, as new networks are added infrequently.

ACKs for top commit:
  tcharding:
    ACK 028a0d6558129f554de8c4247481bc0ad80f1c27
  apoelstra:
    ACK 028a0d6558129f554de8c4247481bc0ad80f1c27; successfully ran local tests

Tree-SHA512: 07b768e224122950e4d7b5627264a437169

16 of 17 new or added lines in 1 file covered. (94.12%)

1 existing line in 1 file now uncovered.

23468 of 27823 relevant lines covered (84.35%)

15950.65 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
80.54
 0.88% bitcoin/src/p2p/mod.rs

Coverage Regressions

Lines Coverage ∆ File
1
85.85
 -0.06% bitcoin/src/psbt/mod.rs
Jobs
ID Job ID Ran Files Coverage
1 15449682371.1 130
84.35
 GitHub Action Run
Source Files on build 15449682371