Qiskit / qiskit / 15448269763

88%

Build Type

push

github

Committed by web-flow

Commit Message

Initial `Target` C API (#14248)

* Initial: Enable a C API to build and modify a Target

* Add: `add_instruction` function

* Add: More methods to `Target` C API
- Add provisional `PropertyMap` to represent the mapping of `qargs : InstructionProperties` before adding it to the `Target`.
- `InstructionProperties`:
    - free.
- `Target`:
    - `update_instruction_prop`
    - `operation_names`
    - `physical_qubits`
    - `non_global_operation_names`.
    - `operation_names_for_qargs`.
    - `qargs_for_operation_names`.
    - `qargs`.
    - `instruction_supported`.
    - `contains_key`.

* Add: C unit test
- Add getter methods for `InstructionProperties`.
- Add `length` method for `PropertyMap`.
- Add name maping for `PropertyMap`.

* Fix: Add `IndexMap` and `Ahash` dependencies to qiskit_cext.
- Add `get` method to `Target`.
- Add missing methods to `PropertyMap`.
- Fix methods returning arrays to C by adding a a forget statement to prevent pointer from being destroyed.
- Add getter methods to the `C` api of target.
- Add helper function to parse qargs.

* Test: Add tests to update properties and get non global names.

* Add `operation_names_for_qargs` test case.
- Move `print_qargs` helper to top of module.

* Add: `qargs_for_operation_names` test case
- Add helper method to compare arrays.
- Fix print method for qargs.

* Docs: Add first wave of docstrings.

* Fix: Incorrect typing in `test_target.c`

* Fix: Add missing docstrings.
- Use correct type of pointers for outputs,

* Lint: Fix c-format

* Fix: Remove option from `qarg_gate_map`.
- Use IndexSet to preserve insertion order to avoid sorting in the C API.

* Test: Add `qargs` test.

* FIx: Add missing docstrings for remainign tests

* Fix: Type errors in MacOS

* Fix: Undo extra changes in the target.
- Sort the string arrays obtained from the target in C during tests.
- Remove `Copy` from `InstructionProperties`.
- Add helper method to sort string array outputs, coming from the Target.

* Ad... (continued)

Run Details

276 of 316 new or added lines in 5 files covered. (87.34%)

4 existing lines in 2 files now uncovered.

81671 of 92887 relevant lines covered (87.93%)

524796.35 hits per line