tarantool / luajit / 15448724747

93%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

Fix another potential file descriptor leak in luaL_loadfile*().

Reported by Peter Cawley.

(cherry picked from commit ab39082fd)

`loadfile()` doesn't close the fd in case when `fopen()` results
successfully, but then the file can't be read (since it is a directory,
for example) or parser failure occurs for some reason.

This patch fixes that behaviour by moving the error formatting after the
cleanup of the descriptor.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#11278

Coverage Stats

5705 of 6041 branches covered (94.44%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

8 existing lines in 3 files now uncovered.

21774 of 23492 relevant lines covered (92.69%)

3831320.35 hits per line