Qiskit / qiskit / 15428348544

88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix qiskit-synthesis crate standalone builds (#14526)

In the recently merged #14203 the bincode dependency was added to the
qiskit-synthesis crate to provide a binary serialization of the computed
basic approximations. However, under the covers this library is using
serde and it depends on having anything passed to it be serde
serializable. When building the qiskit-synthesis crate by itself the
hashbrown crate does not enable the serde feature meaning it doesn't
derive the necessary serialization traits for serde. This didn't show up
in a full build because other libraries pulled in as part of the build
cause serde to be enabled for hashbrown. This commit fixes this by
adding the serde feature to the Cargo.toml for hashbrown to ensure we're
building with the feature required in the crate using it.

This also takes the opportunity to fix some small clippy lint issues
identified by the latest stable version of clippy in the synthesis crate
which were introduced in #14203 and #13929.

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

21 existing lines in 4 files now uncovered.

81384 of 92594 relevant lines covered (87.89%)

525303.47 hits per line