spesmilo / electrum / 4965616366387200

60%

master: 63%

Build Type

Pull #9902

CirrusCI

Committed by SomberNight

Commit Message

base64.b64decode: always set validate=True

Notably verifymessage and decrypt(message) were silently ignoring trailing garbage
or inserted non-base64 characters present in signatures/ciphertext.
(both the CLI commands and in the GUI)
I think it is much cleaner and preferable to treat such signatures/ciphertext as invalid.

In fact I find it surprising that base64.b64decode(validate=False) is the default.
Perhaps we should create a helper function for it that set validate=True and use that.

Pull Request Pull Request #9902: base64.b64decode: always set validate=True

Run Details

9 of 10 new or added lines in 5 files covered. (90.0%)

2 existing lines in 1 file now uncovered.

21852 of 36606 relevant lines covered (59.7%)

2.98 hits per line