Qiskit / qiskit / 15415328831

88%

Build Type

push

github

Committed by web-flow

Commit Message

Improve efficiency of QkCircuitInstruction in C API (#14404)

* Improve efficiency of QkCircuitInstruction in C API

This commit adjusts the decleration and usage of the
QkCircuitInstruction struct in the circuits C API. The larger change is
around the interface for the `qk_circuit_get_instruction` function which
has changed from returning a struct by value to writing it to a
user provided pointer. From a strictly ergonomics PoV the normal use
case of `qk_circuit_get_instruction()` function will typically be used
while iterating over the circuit or getting the details of multiple
instructions, so being able to reuse a single allocation is quite
useful.

Fixes #14390

* Update crates/cext/src/circuit.rs

* Apply suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Update crates/cext/src/circuit.rs

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Use std::ptr::write instead of *ptr =

* Update unitary gate tests to use new get_instruction syntax

* Rename qk_circuit_instruction_free to qk_circuit_instruction_clear

This commit renames the qk_circuit_instruction_free() function to
qk_circuit_instruction_clear(). The function isn't freeing the
allocation for the QkCircuitInstruction object but instead is clearing
out internal allocations. This rename makes it clear that the behavior
here is eparate from the convention on what we're using for qk_*_free()
functions.

* Apply suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

---------

Co-authored-by: Julien Gacon <gaconju@gmail.com>

Run Details

19 of 19 new or added lines in 1 file covered. (100.0%)

12 existing lines in 3 files now uncovered.

80813 of 91977 relevant lines covered (87.86%)

359097.21 hits per line