xapi-project / xen-api / 15387791435
80%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 33
Run time 1915min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 77.719%. Remained the same
15387791435

push

github

web-flow 
Add experimental feature to use hard affinities when using best-effort (CP-54234) (#6491)

This needed:
- Changes in the C bindings to be able to set the hard affinity for each
vcpu. This needed change in the basic call to be able to set hard and
soft affinities, at the same time.
- Stop feeding xenguest the hard affinities when user did not set any in
particular. Prior to the all->all priorities were set instead, with the
misfortune of setting them after the NUMA code had decided the
affinities and set them, overriding the desired values. Fortunately
xenguest is able to cope with the missing values. (edwin found this
strange behaviour)

I took time to fix the exhaustivity issue when defining features, and
now xenopsd sets the hard affinities when the user has hardcoded them
for a VM, instead of sending them for xenguest to read them.

Tests:
- manually tested that soft-pinning works by default
- manually tested that enabling the feature and restart xapi enables
hard-pinning
- manually tested that setting the vcpu mask works (`xe vm-param-set
uuid=A_UUID VCPUs-params:mask=20`)
- manually checked that the all_features contains the same features as
before using the REPL, in case some got forgotten (there are also
unit-tests for the module)

The vcpu affinities were checked using `xl vcpu-list` and restarting a
VM repeatedly while changing the feature and the vm arguments.

3359 of 4322 relevant lines covered (77.72%)

0.78 hits per line

Jobs
ID Job ID Ran Files Coverage
1 python3.11 - 15387791435.1 33
77.72
 GitHub Action Run
Source Files on build 15387791435