15368824317
72%

Ran 01 Jun 2025 02:47AM UTC

Jobs 1

Files 1915

Run time 3min

Badge

Embed ▾

Committed 31 May 2025 06:14PM UTC coverage: 72.029% (+0.005%) from 72.024%

Build # 15368824317

Build Type

push

github

Committed by

yuwata

Commit Message

mount-util: avoid unnecessary mount_setattr() call in make_fsmount()

If .attr_set is zero (and .att_clr, .propagation too), then there's no
point in calling mount_setattr().

Fixes: #37062

Note that this optimization is not precisely load-bearing anymore, since
3cc23a2c2 got merged which removes the
only caller of make_fsmount() that might trigger it. But it's worth
fixing generic code anyway, in case it gets used like this later again.

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

891 existing lines in 47 files now uncovered.

299583 of 415921 relevant lines covered (72.03%)

703729.28 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	81.82	-2.27%	src/basic/errno-util.h
1	97.64	-0.1%	src/basic/hashmap.c
1	82.97	-0.1%	src/basic/process-util.c
1	61.31	-0.6%	src/core/dbus-job.c
1	83.56	-0.15%	src/core/device.c
1	71.45	-0.09%	src/libsystemd-network/sd-dhcp-client.c
1	81.17	-0.25%	src/libsystemd/sd-netlink/netlink-util.c
1	69.62	-0.24%	src/machine/machined-varlink.c
1	85.47	-0.13%	src/network/networkd-dhcp-prefix-delegation.c
1	95.19	-0.08%	src/resolve/resolved-dns-rr.c
1	75.53	0.0%	src/resolve/resolved-dns-transaction.c
1	79.95	-0.27%	src/shared/bus-polkit.c
1	91.67	0.0%	src/shared/dissect-image.h
1	72.99	-0.03%	src/shared/mount-util.c
1	66.67	-0.76%	src/stdio-bridge/stdio-bridge.c
1	58.26	-0.17%	src/timesync/timesyncd-manager.c
1	72.21	-0.13%	src/udev/net/link-config.c
1	75.0	-0.48%	src/udev/udev-spawn.c
2	87.5	-0.86%	src/basic/pidref.c
2	72.69	-0.05%	src/core/cgroup.c
2	57.76	-0.41%	src/journal-remote/journal-upload.c
2	82.26	-0.25%	src/libsystemd-network/sd-dhcp-server.c
2	82.0	-0.25%	src/libsystemd/sd-bus/bus-socket.c
2	83.56	-0.18%	src/network/networkd-route.c
2	27.7	-0.27%	src/udev/udev-builtin-net_id.c
3	77.53	-0.26%	src/resolve/resolved-manager.c
3	86.17	-0.4%	src/udev/udev-manager.c
3	79.92	-0.17%	src/udev/udev-rules.c
4	45.7	-1.56%	src/journal/journald-native.c
4	88.49	-0.16%	src/network/networkd-address.c
4	99.07	0.0%	src/resolve/test-dns-cache.c
5	48.03	-0.48%	src/nsresourced/nsresourcework.c
6	84.61	-0.31%	src/network/networkd-link.c
7	69.75	0.47%	src/resolve/resolved-dns-scope.c
7	81.92	0.12%	src/resolve/resolved-link.c
8	70.13	-1.46%	src/journal-remote/journal-remote-main.c
8	76.6	-1.51%	src/journal-remote/journal-upload-journal.c
17	0.0	0.0%	src/shared/common-signal.c
19	8.75	-0.22%	src/core/crash-handler.c
21	64.71	0.96%	src/shared/extension-util.c
30	78.41	0.02%	src/shared/dissect-image.c
36	78.24	-0.21%	src/coredump/coredumpctl.c
58	75.27	-0.35%	src/udev/udev-watch.c
80	78.41	-0.12%	src/sysext/sysext.c
105	81.47	0.0%	src/portable/portable.c
174	82.52	-0.05%	src/core/namespace.c
257	74.7	-0.5%	src/journal/journald-manager.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	15368824317.1	01 Jun 2025 02:47AM UTC	1915	72.03	GitHub Action Run

systemd / systemd / 15368824317
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 15368824317

systemd / systemd / 15368824317 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 15368824317

systemd / systemd / 15368824317
72%

README BADGES
x