lslezak / agama / 15349560025

81%

push

github

fix(registration): Change the SLES and SLES_SAP version from "16-0" to "16.0" (bsc#1243788) (#2425)

## Problem

- Registration against RMT server fails with "No product found" error
- https://bugzilla.suse.com/show_bug.cgi?id=1243788

## Details

- When registering the system the registration target was set to
`SLES-16-0-x86_64`, although that works fine with SCC it does not work
with RMT. It accepts only the `SLES-16-x86_64` identifier. That works
fine with SCC as well.
- In the past (SLES15) there were some problems regarding the dash
separator in the data, maybe SCC accepts it but it can be missing. RMT
seems to be more strict and does not accept it.

## Solution

- Remove the dash, use version "16.0"
- The minor version is removed by [this
code](https://github.com/agama-project/agama/blob/9c32c1182/service/lib/agama/registration.rb#L255)
so the `SLES-16-x86_64` identifier is sent to the server in the end.
- Added some more logging to see what exactly has been sent to the
registration server.

## Testing

- Tested manually against both RMT and SCC, works fine in both cases.
- Tested also in Full SLES medium, works fine as well (but I tested it
in some older image, the Full image is huge to download).

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

18475 of 25940 relevant lines covered (71.22%)

46.0 hits per line