tari-project / tari / 15326284040
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 687
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 72.791% (-0.8%) from 73.545%
15326284040

push

github

web-flow 
fix: peer retention and connections (#7123)

Description
---
- Fixed peer retention in the database by improving delete all stale
peers logic.
- Improved error responses when peers could not be found in the
database.
- Improved DHT connection pools sync with peer database.

Motivation and Context
---
DHT neighbour and random pools were not in sync with actual connections
and peers in the peer db.

Issue - Why `PeerManagerError(PeerNotFoundError)`
```
2025-05-28 04:49:55.101009900 [comms::dht::connectivity] ERROR Error refreshing neighbour peer pool: PeerManagerError(PeerNotFoundError)
2025-05-28 04:49:55.101120100 [comms::connectivity::manager] TRACE Request (14743808475136314793): GetAllowList(Sender { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: true, is_tx_task_set: false } }) })
2025-05-28 04:49:55.101160300 [comms::connectivity::manager] TRACE Request (14743808475136314793) done
2025-05-28 04:49:55.104823200 [comms::dht::connectivity] ERROR Error refreshing random peer pool: PeerManagerError(PeerNotFoundError)
```
Issue  -  Why `0 connected` but `active DHT connections: 10/12`
```
2025-05-28 04:49:55.104929100 [comms::dht::connectivity] DEBUG DHT connectivity status: neighbour pool: 8/8 (0 connected), random pool: 4/4 (0 connected, last refreshed 12777s ago), active DHT connections: 10/12
```
Issue - Why `Inbound pipeline returned an error: 'The requested peer
does not exist'`
```
2025-05-28 10:42:21.447513700 [comms::pipeline::inbound] WARN  Inbound pipeline returned an error: 'The requested peer does not exist'
```
How Has This Been Tested?
---
- Adapted unit test for improved delete all stale peers logic.
- System-level testing [**TBD**]

What process can a PR reviewer use to test or verify this change?
---
- Code review.
- System-level testing

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be ... (continued)

163 of 194 new or added lines in 11 files covered. (84.02%)

1028 existing lines in 27 files now uncovered.

82035 of 112699 relevant lines covered (72.79%)

252963.2 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
57.91
 0.52% comms/core/src/connectivity/manager.rs
1
91.25
 0.0% comms/core/src/peer_manager/peer_storage_sql.rs
5
86.13
 0.0% comms/core/src/peer_manager/manager.rs
6
88.5
 -0.0% comms/core/src/peer_manager/storage/database.rs
18
63.86
 0.5% comms/dht/src/connectivity/mod.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
99.15
 -0.85% base_layer/common_types/src/dammsum.rs
1
85.43
 -0.04% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
1
99.32
 -0.18% comms/dht/src/network_discovery/test.rs
1
0.0
 -100.0% comms/dht/src/rpc/mod.rs
2
83.01
 -0.97% base_layer/core/src/transactions/transaction_key_manager/storage/sqlite_db/mod.rs
2
88.48
 -0.41% base_layer/p2p/src/services/liveness/service.rs
2
90.8
 -0.25% comms/core/src/multiplexing/yamux.rs
2
80.0
 60.0% comms/core/src/peer_manager/error.rs
2
63.86
 0.5% comms/dht/src/connectivity/mod.rs
3
0.0
 0.0% base_layer/core/src/base_node/state_machine_service/initializer.rs
3
64.35
 -0.11% base_layer/core/src/chain_storage/blockchain_database.rs
4
81.82
 -9.85% base_layer/core/src/base_node/sync/config.rs
5
0.0
 -66.67% comms/dht/src/rpc/mock.rs
6
0.0
 -35.29% comms/dht/src/network_discovery/waiting.rs
7
0.0
 0.0% comms/dht/src/network_discovery/on_connect.rs
12
81.63
 -6.12% comms/core/src/test_utils/mocks/connectivity_manager.rs
18
52.1
 -15.13% comms/core/src/protocol/rpc/server/mock.rs
36
35.21
 -1.83% base_layer/core/src/base_node/state_machine_service/states/starting_state.rs
41
63.39
 -0.29% base_layer/core/src/mempool/mempool_storage.rs
44
60.89
 -10.07% base_layer/core/src/base_node/state_machine_service/state_machine.rs
57
0.0
 -70.59% comms/dht/src/network_discovery/initializing.rs
83
16.02
 4.26% base_layer/core/src/base_node/state_machine_service/states/events_and_states.rs
87
38.82
 -25.46% comms/dht/src/network_discovery/ready.rs
114
89.07
 -3.37% base_layer/core/src/transactions/transaction_protocol/sender.rs
161
46.34
 -12.85% base_layer/core/src/base_node/state_machine_service/states/listening.rs
164
32.52
 -29.91% comms/dht/src/network_discovery/state_machine.rs
169
0.0
 -72.46% comms/dht/src/network_discovery/discovering.rs
Jobs
ID Job ID Ran Files Coverage
1 15326284040.1 687
72.79
 GitHub Action Run
Source Files on build 15326284040