bolshakov / stoplight / 15327903014

100%

push

github

Implement clock skew detection (#323)

Stoplight's distributed, leader-less architecture relies on time-based coordination for circuit breaker decisions. Clock skew between servers can cause inconsistent behavior:

- Different instances may see different error counts for the same time window
- Recovery timing coordination becomes unreliable
- Color transitions may occur at different times across the instances

This PR introduces automatic clock skew detection in the Redis Data Store:

* Probabilistic checking: Runs detection ~1% of the time to minimize performance impact
* Configurable warnings: Can be disabled via `warn_on_clock_skew: false` parameter
* Clear guidance: Warning messages link to wiki documentation

Example warning:

> Detected clock skew between Redis and the application server. Redis time: 1748277980, Application time: 1748274380. See https://github.com/bolshakov/stoplight/wiki/Clock-Skew-and-Stoplight-Reliability

Usage:

```ruby
# Default behavior - warnings enabled
data_store = Stoplight::DataStore::Redis.new(redis)

# Disable warnings if needed (e.g., testing environments)
data_store = Stoplight::DataStore::Redis.new(redis, warn_on_clock_skew: false)
```

14 of 14 new or added lines in 1 file covered. (100.0%)

829 of 829 relevant lines covered (100.0%)

907.53 hits per line