Qiskit / qiskit / 15308608693

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add method to get a UnitaryGate ArrayView2 without copying (#14249)

* Add method to get a UnitaryGate ArrayView2 without copying

This commit adds a new method `UnitaryGate::matrix_view()` which
returns an ArrayView2 without copying data or allocating a new array.
We have direct access to an owned array when we're working with a
UnitaryGate in a circuit so for things that are read only on that matrix
we can work with a view and avoid a copy or conversion. Ndarray is
also flexible enough that we can provide a view on top of an nalgebra
matrix and not need to copy the data. After adding the method places
where this is used in the transpiler are updated to leverage the method.

At the same time this commit reworks the use of the dag builder
interface the two passes that are using this new method. Previously,
they were using it incorrectly, or not at all. Since the code was all
being refactored this was cleaned up as part of the refactoring.

* Update top half of split unitary pass too

* Remove another to_vec

* Fix rebase issues

* Fix rebase issues

* Add docstring to matrix_view() method

Run Details

117 of 123 new or added lines in 3 files covered. (95.12%)

7 existing lines in 4 files now uncovered.

79540 of 90558 relevant lines covered (87.83%)

414803.29 hits per line