nestjs / nest / 1f6b5b1d-daeb-436c-aada-06efda4279f4

89%

master: 90%

Build Type

Pull #15201

circleci

Committed by dzhlobo

Commit Message

fix(core): gracefully shutdown the app when repl exits

The application module we pass to repl may have long-running phases
(e.g. database connection polling) and if we don't finish those
long-running phases the repl would stuck on exit possibly forever.

I encoutered this issue while using MikroORM.forRoot module.

The solution is to call `app.close()` when repl exits. Modules should
implement graceful shutdown using lifecycle hooks.

Pull Request Pull Request #15201: fix(core): gracefully shutdown the app when repl exits

Run Details

2711 of 3425 branches covered (79.15%)

0 of 2 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

7197 of 8094 relevant lines covered (88.92%)

16.3 hits per line