safe-global / safe-smart-account / 15269233035

94%

push

github

Ackee[W1]: Less Confusing Event Emission (#973)

We simplified the `ExtensibleFallbackHandler` to use a single event,
instead of selecting an event depending on the parameters. This makes
the events more consistent with the other Safe contract events, namely:

- We roughly emit one event per method (so, `setFallbackHandler` or
`setGuard` also do not distinguish between enabling and disabling, while
`addOwner` and `removeOwner` do)
- We consistently emit an event regardless of whether or not the storage
actually changed.

319 of 360 branches covered (88.61%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 2 files covered. (100.0%)

490 of 502 relevant lines covered (97.61%)

102.53 hits per line