topfreegames / pitaya / 15259244342

62%

master: 69%

Build Type

push

github

Committed by web-flow

Commit Message

Fix some unique session kick failures preventing clients to bind new sessions (#452)

* Remove UID from session pool and clean subscriptions correctly when kicking user
* Force close old session if kick fails when enforcing unique sessions
* Wrap errors within agent kick to facilitate debugging
* Add integration test case to validate unique sessions module basic behavior
* Use correct deadline exceeded error to validate write timeout
* Fix SessionCount being decremented if session is already closed and Close is called again
* Force close old session if kick fails due to 'use of closed connection' when enforcing unique sessions
* Improve logs
* Rename new unique session private method
* Add e2e test to validate unique session doesn't fail if kick fails
* Add comment to propose future improvement
* chore: update go to 1.23
* chore(ci): fix setup with goveralls deps
* feat(session): propagate network errors on Kick

Kick might fail due to encoding and verious network errors during
write. Also, if Kick tries to write to a closed connection (fd) it
would do so without timeout, defaulting to the OS timeouts in the
order of minutes. New Kick behavior does:

- Uses writeConnection that sets write deadlines
- Propagate encode errors so client can decide to retry
- Propagate network errors so client can decide to ignore

Knowing the error is specially useful in unique_session module, which
we need to ensure existing session is always closed, regardless of a
successful Kick.


---------

Co-authored-by: Felippe Durán <felippe.duran@wildlifestudios.com>
Co-authored-by: Pedro Soares <pedro.soares@wildlifestudios.com>

Run Details

105 of 110 new or added lines in 4 files covered. (95.45%)

2 existing lines in 1 file now uncovered.

5198 of 8243 relevant lines covered (63.06%)

0.69 hits per line