spesmilo / electrum / 5908696527536128

59%

master: 63%

Build Type

Pull #9871

CirrusCI

Committed by SomberNight

Commit Message

adb.get_tx_height: return "LOCAL" height if missing full signed tx

get_tx_height previously did not consider whether the walletDB has the full tx for
the corresponding txid, and could consider a tx even "mined" and spv-ed, even if
we were missing the raw tx.
Now if the full tx is missing or the tx in the db is partial,
get_tx_height considers it to be LOCAL.

In particular the txbatcher, in `run_iteration`,
- first saves a tx as local *unsigned* (to reserve UTXOs),
- then signs it and tries to broadcast it.

The history tx will later transition to local and signed,
after we get back the broadcasted tx via the Synchronizer dance.
In the meantime there is a race where we have an unsigned tx in the history,
but the txid could already transition to mempool or even to mined,
before we download the full raw tx from the server.
During that time window, it makes the adb state more consistent
to just consider the history tx to be local, as done here.

Pull Request Pull Request #9871: adb.get_tx_height: return "LOCAL" height if missing full signed tx

Run Details

9 of 9 new or added lines in 2 files covered. (100.0%)

23 existing lines in 2 files now uncovered.

21659 of 36403 relevant lines covered (59.5%)

2.38 hits per line