rust-bitcoin / rust-bitcoin / 15255853031

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4554: Sane InputWeightPredition Arbitrary Type

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/8dd24cb67b948e619038b387d6c3bd79252a5de1">8dd24cb67 Add Arbitrary type for InputWeightPrediction (yancy)

Pull request description:

  This type creates sane Arbitrary InputWeightPrediction types that do not panic.  To this end, when a custom type is created by calling new() or from_slice() constructor, only use values that would no greater than block size 4 MB of witness data or 1 MB of non-witness data.  This idea is from the discussion here  https://github.com/rust-bitcoin/rust-bitcoin/issues/4547

  I'd be up for a future PR that limits the constructors to no greater than 1MB or 4MB witness data, although I feel like this Arbitrary type will be less controversial.

  Furthermore, I did test this locally against my application and no panics where produced either through the constructor nor auxiliary methods `total_weight` or `witness_weight`.

ACKs for top commit:
  tcharding:
    ACK 8dd24cb67b948e619038b387d6c3bd79252a5de1
  apoelstra:
    ACK 8dd24cb67b948e619038b387d6c3bd79252a5de1; successfully ran local tests

Tree-SHA512: ff33f1a6c01cda040542fec0c8be5e52722

Coverage Stats

0 of 21 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

23525 of 27797 relevant lines covered (84.63%)

15864.01 hits per line