|
Ran
|
Jobs
1
|
Files
518
|
Run time
1min
|
Badge
README BADGES
|
push
github
cmake: fix LTO build on Fedora This patch is a follow-up to the commit 25af976f5 ("build: support cmake 4.0"). Since version 3.4, CMake doesn't add flags to export symbols from executables without the ENABLE_EXPORTS target property, see CMP0065 [1] for details. Without this property, some unit C tests produce build warnings with LTO optimization enabled (for example, on Fedora 39): NO_WRAP ``` [ 72%] Linking CXX executable luaT_tuple_new.test In function ‘rmean_collect’, inlined from ‘txn_complete_success’ at src/box/txn.c:836:2, inlined from ‘txn_limbo_complete’ at src/box/txn_limbo.c:205:3: src/lib/core/rmean.c:65:9: error: ‘__atomic_add_fetch_8’ writing 8 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=] 65 | __atomic_add_fetch(&rmean->stats[name].value[0], value, __ATOMIC_RELAXED); | ^ In function ‘txn_limbo_complete’: lto1: note: destination object is likely at address zero ``` NO_WRAP The real reason should be investigated in the scope of #11517. The compilation warning may be suppressed, but it may also mask the actual problems in the future tests. The CMP0065 is removed from CMake version 4.0 [2]. Thus, this patch fixes the behaviour by setting the property `ENABLE_EXPORTS` for unit tests directly. [1]: https://cmake.org/cmake/help/latest/policy/CMP0065.html [2]: https://cmake.org/cmake/help/latest/manual/cmake-policies.7.html#policies-introduced-by-cmake-3-4-removed-by-cmake-4-0 NO_DOC=build NO_TEST=build NO_CHANGELOG=build (cherry picked from commit 2bde9262e)
70436 of 124145 branches covered (56.74%)
103575 of 118367 relevant lines covered (87.5%)
2770114.11 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
95.21 |
1.06% | src/box/vy_range.c |
| 1 |
91.21 |
0.2% | src/box/vy_scheduler.c |
| 1 |
95.4 |
-1.15% | src/lib/core/histogram.c |
| 1 |
97.26 |
0.1% | src/lib/msgpuck/msgpuck.h |
| 2 |
92.49 |
-0.04% | src/box/vinyl.c |
| 2 |
84.29 |
-0.05% | src/box/xlog.c |
| 2 |
89.25 |
-0.11% | src/box/xrow.c |
| 2 |
85.71 |
-9.52% | src/lib/core/tt_sigaction.c |
| 4 |
87.44 |
-0.27% | src/box/vy_run.c |
| 6 |
95.2 |
-1.25% | src/box/vy_read_iterator.c |
| 8 |
60.84 |
-3.13% | src/lib/core/fio.c |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 15253966204.1 | 518 |
87.5 |
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
|---|