|
Ran
|
Jobs
1
|
Files
514
|
Run time
1min
|
Badge
README BADGES
|
push
github
cmake: fix LTO build on Fedora This patch is a follow-up to the commit 25af976f5 ("build: support cmake 4.0"). Since version 3.4, CMake doesn't add flags to export symbols from executables without the ENABLE_EXPORTS target property, see CMP0065 [1] for details. Without this property, some unit C tests produce build warnings with LTO optimization enabled (for example, on Fedora 39): NO_WRAP ``` [ 72%] Linking CXX executable luaT_tuple_new.test In function ‘rmean_collect’, inlined from ‘txn_complete_success’ at src/box/txn.c:836:2, inlined from ‘txn_limbo_complete’ at src/box/txn_limbo.c:205:3: src/lib/core/rmean.c:65:9: error: ‘__atomic_add_fetch_8’ writing 8 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=] 65 | __atomic_add_fetch(&rmean->stats[name].value[0], value, __ATOMIC_RELAXED); | ^ In function ‘txn_limbo_complete’: lto1: note: destination object is likely at address zero ``` NO_WRAP The real reason should be investigated in the scope of #11517. The compilation warning may be suppressed, but it may also mask the actual problems in the future tests. The CMP0065 is removed from CMake version 4.0 [2]. Thus, this patch fixes the behaviour by setting the property `ENABLE_EXPORTS` for unit tests directly. [1]: https://cmake.org/cmake/help/latest/policy/CMP0065.html [2]: https://cmake.org/cmake/help/latest/manual/cmake-policies.7.html#policies-introduced-by-cmake-3-4-removed-by-cmake-4-0 NO_DOC=build NO_TEST=build NO_CHANGELOG=build (cherry picked from commit 2bde9262e)
68922 of 122199 branches covered (56.4%)
101607 of 116253 relevant lines covered (87.4%)
1948474.01 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 15 |
91.95 |
-2.32% | src/box/memtx_space.c |
| 5 |
91.26 |
-0.1% | src/box/box.cc |
| 4 |
94.25 |
-0.78% | src/box/xrow_update_field.c |
| 3 |
94.53 |
-0.96% | src/box/gc.c |
| 3 |
93.62 |
-1.06% | src/box/vy_range.c |
| 3 |
90.9 |
-0.31% | src/box/vy_scheduler.c |
| 3 |
22.64 |
-0.04% | src/lib/uri/uri_parser.c |
| 2 |
92.15 |
-0.05% | src/box/vinyl.c |
| 2 |
92.94 |
-0.2% | src/lib/core/fiber.c |
| 1 |
85.48 |
-1.61% | src/box/lua/ctl.c |
| 1 |
92.45 |
-0.47% | src/box/recovery.cc |
| 1 |
95.15 |
-0.13% | src/box/replication.cc |
| 1 |
80.74 |
-0.33% | src/box/tuple_bloom.c |
| 1 |
93.56 |
-0.16% | src/box/txn_limbo.c |
| 1 |
95.89 |
-0.21% | src/box/vy_read_iterator.c |
| 1 |
96.55 |
-1.15% | src/histogram.c |
| 1 |
96.55 |
-0.86% | src/lib/vclock/vclock.c |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 15253969213.1 | 514 |
87.4 |
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
|---|