|
Ran
|
Jobs
1
|
Files
518
|
Run time
1min
|
Badge
README BADGES
|
push
github
cmake: fix LTO build on Fedora This patch is a follow-up to the commit 25af976f5 ("build: support cmake 4.0"). Since version 3.4, CMake doesn't add flags to export symbols from executables without the ENABLE_EXPORTS target property, see CMP0065 [1] for details. Without this property, some unit C tests produce build warnings with LTO optimization enabled (for example, on Fedora 39): NO_WRAP ``` [ 72%] Linking CXX executable luaT_tuple_new.test In function ‘rmean_collect’, inlined from ‘txn_complete_success’ at src/box/txn.c:836:2, inlined from ‘txn_limbo_complete’ at src/box/txn_limbo.c:205:3: src/lib/core/rmean.c:65:9: error: ‘__atomic_add_fetch_8’ writing 8 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=] 65 | __atomic_add_fetch(&rmean->stats[name].value[0], value, __ATOMIC_RELAXED); | ^ In function ‘txn_limbo_complete’: lto1: note: destination object is likely at address zero ``` NO_WRAP The real reason should be investigated in the scope of #11517. The compilation warning may be suppressed, but it may also mask the actual problems in the future tests. The CMP0065 is removed from CMake version 4.0 [2]. Thus, this patch fixes the behaviour by setting the property `ENABLE_EXPORTS` for unit tests directly. [1]: https://cmake.org/cmake/help/latest/policy/CMP0065.html [2]: https://cmake.org/cmake/help/latest/manual/cmake-policies.7.html#policies-introduced-by-cmake-3-4-removed-by-cmake-4-0 NO_DOC=build NO_TEST=build NO_CHANGELOG=build (cherry picked from commit 2bde9262e)
70015 of 123907 branches covered (56.51%)
103081 of 117809 relevant lines covered (87.5%)
2112610.34 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
91.29 |
-0.03% | src/box/box.cc |
| 1 |
92.51 |
0.14% | src/box/vinyl.c |
| 1 |
84.35 |
0.18% | src/box/xlog.c |
| 1 |
96.55 |
-1.15% | src/lib/core/histogram.c |
| 1 |
97.46 |
0.41% | src/lib/msgpuck/msgpuck.h |
| 2 |
95.96 |
-0.37% | src/box/relay.cc |
| 2 |
84.53 |
-0.72% | src/lib/core/coio.c |
| 2 |
94.22 |
-0.39% | src/lua/fiber.c |
| 3 |
91.7 |
-0.58% | src/box/gc.c |
| 3 |
90.9 |
-0.31% | src/box/vy_scheduler.c |
| 4 |
93.62 |
-0.53% | src/box/vy_range.c |
| 4 |
94.25 |
-0.8% | src/box/xrow_update_field.c |
| 4 |
93.31 |
-1.27% | src/lib/swim/swim_io.c |
| 6 |
94.66 |
-1.23% | src/box/vy_read_iterator.c |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 15253967726.1 | 518 |
87.5 |
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
|---|