rust-bitcoin / rust-bitcoin / 15228743837

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4496: BREAKING: Change Psbt serde implementations

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/9aa235c24d65d23de2afc21fcbd019892bf4ad2a">9aa235c24<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/ecf4b2bceeafa1c736ca26e6089980a846d76328"> BREAKING: Change Psbt serde implementations (Daniel Roberts)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d7e9a8433939e23838123932ef0186fe315e5c42">d7e9a8433</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/ecf4b2bceeafa1c736ca26e6089980a846d76328"> Fix Psbt preimage keys in serde test (Daniel Roberts)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/62026c1e2dd0a1d0b8f12fc6d55c06de0ddc002e">62026c1e2</a> Don't use PSBT_GLOBAL_XPUB as an unknown key in Psbt serde test (Daniel Roberts)

Pull request description:

  Implements the conclusion of #3454 by serializing Psbts using the BIP-174 binary encoding, optionally using base64 where appropriate.

  The core of the problem is the old derived serde implementation by its nature can't be backwards compatible when serialized in binary formats like bincode. Fields will be added to the Psbt (my motivating case in #4440 ) and this will always break formats like bincode.

ACKs for top commit:
  apoelstra:
    ACK 9aa235c24d65d23de2afc21fcbd019892bf4ad2a; successfully ran local tests
  tcharding:
    ACK 9aa235c24d65d23de2afc21fcbd019892bf4ad2a

Tree-SHA512: 4dc9dbf1a8769c66c2f58da2cc1bc1b7382

Coverage Stats

20 of 28 new or added lines in 1 file covered. (71.43%)

27 existing lines in 3 files now uncovered.

23523 of 27781 relevant lines covered (84.67%)

16012.06 hits per line