Qiskit / qiskit / 15207588753
88%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 810
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.326% (-0.008%) from 88.334%
15207588753

push

github

web-flow 
Remove DT from C API for adding delays (#14374)

* Remove DT from C API for adding delays

The C API for adding delay only handled the case of floating point
values for the delay. However one of the available units was dt. This
isn't actually correct usage because dt is represented by an integer
value not a floating point. While this is expressible in the data model
it violates the expectations of the delay operation and likely would
have caused unexpected behavior when the circuit is used elsewhere.
Right now the rust data model doesn't natively model the integer
duration because it's not a valid variant on the Param enum, so the
delay instruction is modeling it by wrapping it in a PyObject. To
express dt unit delays from the C API we will need to store ints in
Rust before we can add this to the API. After we do this then we'll
probably want to add a new function qk_circuit_delay_dt() to represent
the different typing. This is similar to what will need to happen for
representing stretch durations from C as well.

Also since we haven't released the C API for circuits we didn't need a
dedicated release note because this is all part of the new feature for
exposing circuits to the C API. Having individual release notes for each
new function is a bit redudant. The new function is definitely very
important but we just didn't need a dedicated release note entry for it.

* Remove dt usage from unit tests

78468 of 88839 relevant lines covered (88.33%)

468299.67 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
94.85
 0.0% crates/transpiler/src/passes/unitary_synthesis.rs
4
92.48
 -0.25% crates/qasm2/src/lex.rs
12
97.15
 -0.93% crates/qasm2/src/parse.rs
Jobs
ID Job ID Ran Files Coverage
1 15207588753.1 810
88.33
 GitHub Action Run
Source Files on build 15207588753