jcronenberg / agama / 15206508745
63%

DEFAULT BRANCH: master
Ran
Jobs 3
Files 532
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 62.732% (-0.4%) from 63.096%
15206508745

push

github

web-flow 
UI: handle reused MD RAIDs that are already included in the configuration (#2346)

## Problem

If a storage configuration includes reusing an existing MD RAID device,
such a device is not displayed at the Agama configuration UI. But
actually that case is not so different from using a disk.

## Solution

This extends the component `ConfigEditor` to also display reused MD
RAIDs, offering the same capabilities that are there for disks (like
creating partitions or defining what to do with the existing ones).


![md0b](https://github.com/user-attachments/assets/57e3be40-79fd-469e-aa7f-bf461780eb8b)


![md0a](https://github.com/user-attachments/assets/2181aabd-49d9-46c6-8eb9-66d9b2896d27)

This does not offer any possibility to remove the RAID from the
configuration or to add a new RAID. It only works with RAIDs that are
already present at the loaded configuration.

## Implementation notes

Some of the pre-existing components like `DriveEditor`,
`SpacePolicySelection` or `PartitionsPage` use the old queries at
`config-model.ts` to communicate with the backend. Something that is
deprecated in favor of
https://gist.github.com/joseivanlopez/a8d1e4269e6f1c8d41837dfd89fb556d?permalink_comment_id=5569616

This pull request gives several steps on the agreed direction, but a few
inner components still use the old approach.

## Testing

- Tested manually
- Backend tests reorganized and expanded
- Frontend tests updated

92 of 132 branches covered (69.7%)

Branch coverage included in aggregate %.

96 of 98 new or added lines in 12 files covered. (97.96%)

1716 existing lines in 51 files now uncovered.

11031 of 17599 relevant lines covered (62.68%)

39.62 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
0.0
 0.0% service/lib/agama/storage/config_conversions/from_model_conversions.rb
1
0.0
 0.0% service/lib/agama/storage/config_conversions/to_model_conversions.rb

Uncovered Existing Lines

Lines Coverage ∆ File
1
98.72
 0.0% service/lib/agama/storage/config.rb
2
0.0
 -100.0% rust/agama-locale-data/src/language.rs
2
0.0
 -100.0% rust/agama-locale-data/src/territory.rs
2
0.0
 -50.0% rust/agama-network/src/adapter.rs
2
0.0
 0.0% service/lib/agama/storage/config_conversions/from_model_conversions.rb
2
0.0
 0.0% service/lib/agama/storage/config_conversions/to_model_conversions.rb
3
0.0
 -11.11% rust/agama-lib/src/manager/http_client.rs
4
82.61
 -17.39% rust/agama-locale-data/src/timezone_part.rs
4
0.0
 -94.59% rust/agama-server/src/l10n/model/keyboard.rs
4
0.0
 -100.0% rust/agama-server/src/web/service.rs
4
0.0
 -74.19% rust/agama-server/tests/common/mod.rs
5
0.0
 -71.43% rust/agama-lib/src/lib.rs
5
0.0
 -100.0% rust/agama-lib/src/localization/http_client.rs
5
0.0
 -100.0% rust/agama-lib/src/storage/http_client.rs
5
0.0
 -71.43% rust/agama-lib/src/storage/store.rs
5
0.0
 -100.0% rust/agama-locale-data/src/keyboard/xkb_config_registry.rs
7
0.0
 -100.0% rust/agama-lib/src/utils/transfer.rs
8
0.0
 0.0% rust/agama-server/src/storage/web/iscsi.rs
8
0.0
 0.0% rust/agama-server/src/web/common.rs
9
0.0
 -90.0% rust/agama-lib/src/utils/transfer/handlers/generic.rs
9
0.0
 0.0% rust/agama-server/src/web.rs
11
0.0
 -47.83% rust/agama-lib/src/questions/http_client.rs
11
0.0
 -55.0% rust/agama-lib/src/software/http_client.rs
12
0.0
 -66.67% rust/agama-cli/src/auth_tokens_file.rs
13
0.0
 -81.25% rust/agama-lib/src/software/store.rs
14
0.0
 -70.0% rust/agama-network/src/settings.rs
16
0.0
 -69.57% rust/agama-lib/src/file_source.rs
16
0.0
 -84.21% rust/agama-lib/src/localization/store.rs
17
0.0
 0.0% rust/agama-lib/src/issue.rs
18
0.0
 -33.96% rust/agama-lib/src/product/http_client.rs
18
0.0
 -85.71% rust/agama-lib/src/users/http_client.rs
18
0.0
 -29.03% rust/agama-network/src/types.rs
18
0.0
 -48.57% rust/agama-server/src/network/web.rs
19
25.64
 25.64% rust/agama-lib/src/profile.rs
20
0.0
 -23.26% rust/agama-network/src/nm/model.rs
21
0.0
 -63.64% rust/agama-utils/src/dbus.rs
22
0.0
 -53.66% rust/agama-lib/src/network/store.rs
22
39.02
 -46.34% rust/agama-locale-data/src/locale.rs
24
0.0
 0.0% rust/agama-lib/src/software/client.rs
27
0.0
 -84.38% rust/agama-lib/src/utils/file_format.rs
28
0.0
 -71.79% rust/agama-lib/src/product/store.rs
33
0.0
 -60.0% rust/agama-lib/src/auth.rs
34
19.57
 -73.91% rust/agama-locale-data/src/lib.rs
36
0.0
 -94.74% rust/agama-lib/src/users/store.rs
39
0.0
 -53.42% rust/agama-lib/src/utils/transfer/file_systems.rs
50
0.0
 -76.92% rust/agama-lib/src/software/model/license.rs
53
0.0
 -50.96% rust/agama-lib/src/scripts/model.rs
54
0.0
 -55.67% rust/agama-lib/src/http/base_http_client.rs
99
0.0
 -53.72% rust/agama-network/src/system.rs
325
0.0
 -52.93% rust/agama-network/src/model.rs
532
0.0
 -77.44% rust/agama-network/src/nm/dbus.rs
Jobs
ID Job ID Ran Files Coverage
3 rust - 15206508745.3 117
1.34
 GitHub Action Run
3 service - 15206508744.3 379
89.06
 GitHub Action Run
3 web - 15206508733.3 36
82.3
 GitHub Action Run
Source Files on build 15206508745