Qiskit / qiskit / 15184934187

88%

Build Type

push

github

Committed by web-flow

Commit Message

Remove symengine from the requirements list (#14389)

* Remove symengine from the requirements list

In #13278 we removed our dependency on symengine and replaced it with
our own symbolic engine. However that PR neglected to remove symengine
from the requirements list. This commit corrects this oversight and
removes it from the requirements list. It also updates the release notes
to make them a bit more prescise and document the change in requirements
and potential behavior differences with the new engine.

* Add new optional extra variant for symengine for QPY

* Stop parsing sympy and symengine pulse expressions

During QPY deserialization of old payloads that include pulse schedules
we are unable to construct the pulse schedule from the payload. For
circuits that include pulse gates the strategy for loading those
payloads is to emit a warning that the pulse component will be omitted
and create the rest of the circuit like normal. To do this the qpy
deserialization has to read the size of the payload to seek to the right
position. However we don't need to actually parse the expression because
it's never used. This commit removes the parsing step it is
unnecessary after we do the read that will seek the cursor
appropriately.

* Update releasenotes/notes/parameter-expression-rs-6fddbb2556b7e1f7.yaml

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Remove unused arguments

---------

Co-authored-by: Julien Gacon <gaconju@gmail.com>

Run Details

2 of 9 new or added lines in 1 file covered. (22.22%)

4 existing lines in 2 files now uncovered.

78477 of 88838 relevant lines covered (88.34%)

468139.13 hits per line