Qiskit / qiskit / 15166333040

88%

Build Type

push

github

Committed by web-flow

Commit Message

Clifford+T transpiler pipeline (#14225)

* experiments

* experiment

* clifford plugin

* optimization

* optimization loop

* remove consolidate

* Fix _compute_rotation_axis method

The method used to return [0, 0, 0] for rotation axis when theta is very close to 0 (and yet not within 1e010).
This commit fixes this by noting that the rotation axis of an SO(3) matrix is simply the eigenvector of this
matrix corresponding to eigenvalue 1.

* Fixes related to SU(2) vs. SO(3)

The implemented algorithm has a global phase uncertainty of +-1, due to approximating not the
original SU(2) matrix but its projection onto SO(3). This fixes the global phase of the
computed approximation.

In addition, the product_su2 matrix in GateSequence was not correctly computed in many cases,
leading to incorrect values when using this attribute. Since this is not needed for the actual
algorithm (and spends unnecessary effort for computing it), this also completely removes this
attribute.

Co-authored-by: Almudena Carrera Vazquez <almudenacarreravazquez@hotmail.com>

* Fix the tests.

One of the tests was simply wrong because the reference circuit has the wrong global phase.
The tests that check the gates in the final decomposition should not assume that SGate is included and SdgGate is not.

* reno

* fix to the global phase

* bug fix (forgetting that gate_matrix_su2 is not SU(2) was a sequence)

* adding test

* Undoing changes to SK

* cleanup

* Adding tests for discrete pass manager pipeline

* adding generate_discrete_passmanager to init files

* simplifying import

* another test

* release note

* Fixing tests: with the change to SK plugin, the synthesis algorithm for unitary gates that are Clifford may produce other gates

* In SolovayKitaevSynthesis unitary synthesis plugin now storing a dictionary from the basis set to the SolovayKitaevDecomposition

* adding explicit test

* lint

* remove prints

* renaming

* modifying the default init/translation/optimizati... (continued)

Run Details

64 of 68 new or added lines in 7 files covered. (94.12%)

8 existing lines in 3 files now uncovered.

78425 of 88793 relevant lines covered (88.32%)

457733.31 hits per line