yext / answers-search-ui / 15166287981

62%

master: 62%

Build Type

push

github

Committed by web-flow

Commit Message

Merge master (v1.18.3) into develop (#1933)

* Remove run shell injection vulnerability (#1926)

Prevents attackers from injecting their own code into the github actions runner using variable interpolation to steal screts and code. We now use an intermediate environment variable to store input data.

* Remove run shell injection vulnerability (pt 2) (#1928)

Prevents attackers from injecting their own code into the github actions runner using variable interpolation to steal secrets and code. We now use an intermediate environment variable to store input data (pt 2).

* Deduplicate generative answer sources (#1930)

If an entity is present in search results more than once (e.g. returned by two different verticals) and is cited by the GDA, it appeared in the sources more than one. This change dedupes the search results while determining the sources to prevent this.

* Fix search result vertical list reversal before GDA call (#1932)

The list of search result verticals was reversed before it being sent to the backend for generative answers computation. This patch fixes this bug by changing a mutating array reversal to act on a copy of the list of search result verticals rather than the list itself.

---------

Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com>
Co-authored-by: mkouzel-yext <mkouzel@yext.com>
Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com>

Run Details

2033 of 3437 branches covered (59.15%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

3486 of 5493 relevant lines covered (63.46%)

26.67 hits per line