bitcoindevkit / bdk_wallet / 15165880792

85%

push

github

Merge bitcoindevkit/bdk_wallet#12: fix: no `Debug` on `Display` implementations

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/3c00f1a6cb8e86e35aa2fa64c0376dc65d0056e9">3c00f1a6c<a href="https://github.com/bitcoindevkit/bdk_wallet/commit/635af322a943325e290fa9e64abedce6f3dcc993"> feat: add error messages for CreateWithPersistError Display implementation (Luis Schwab)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk_wallet/commit/c799b52170ee1fd16de8bb5a0d6781447b13f61c">c799b5217</a><a href="https://github.com/bitcoindevkit/bdk_wallet/commit/635af322a943325e290fa9e64abedce6f3dcc993"> fix: remove Debugs from CreateTxError (Luis Schwab)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk_wallet/commit/1721b29a109cecaeee506577a876d41f7bb2f1d3">1721b29a1</a><a href="https://github.com/bitcoindevkit/bdk_wallet/commit/635af322a943325e290fa9e64abedce6f3dcc993"> fix: no Debug on LoadError (Luis Schwab)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk_wallet/commit/187a49487103db2c9f1222017388ddb2b8f1109d">187a49487</a><a href="https://github.com/bitcoindevkit/bdk_wallet/commit/635af322a943325e290fa9e64abedce6f3dcc993"> feat: implement Display for LoadMismatch (Luis Schwab)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk_wallet/commit/0acd80221d823ab8cda17403cdd135f1093eacb0">0acd80221</a> feat: implement Display for KeychainKind (Luis Schwab)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  This PR removes the use of debugs on `Display` implemetations.

  ### Changelog notice
  - Implement Display for KeychainKind.
  - Implement Display for LoadMismatch.
  - Add error message for CreateWithPersistError.
  - The `CreateTxError::LockTime` arm had `requested` and `required` inverted, now fixed.
  - Remove debugs.

  ### Checklists

  #### All Submissions:

  * [X] I've signed all my commits
  * [X] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [X] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    utACK 3c00f1a6cb8e86e35aa2fa64c0376dc65d0056e9

Tree-SHA512: a179841131d2f066e982932f855d9ae5aeb

0 of 85 new or added lines in 4 files covered. (0.0%)

7266 of 8515 relevant lines covered (85.33%)

3468.46 hits per line