FlexMeasures / flexmeasures / 15164539052

74%

push

github

Fix/prefer curtailing later rather than later (#1498)

* fix: wrong field name

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: wrong type (DataFrame should be Series)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: prevent inplace operation

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: changelog entry

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: improve asserts and stop overcharging the EV

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: make Commitment work with prices passed as a single-column DataFrame

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: support single-column DataFrames for other applicable attributes, too

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: try to fetch DatetimeIndex from other applicable attributes, too

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: force type conversion for other applicable attributes, too

Signed-off-by: F.N. Claessen <felix@seita.nl>

* refactor: simplify

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: move start and end to the right timeframe (first hour cheap, second hour more expensive)

Signed-off-by: F.N. Claessen <felix@seita.nl>

* docs: fix typo

Signed-off-by: F.N. Claessen <felix@seita.nl>

* fix: make sure the price slope for preferring to curtail later is much smaller than the price slope for preferring to charge sooner

Signed-off-by: F.N. Claessen <felix@seita.nl>

---------

Signed-off-by: F.N. Claessen <felix@seita.nl>

3968 of 6884 branches covered (57.64%)

Branch coverage included in aggregate %.

13 of 15 new or added lines in 2 files covered. (86.67%)

8621 of 11887 relevant lines covered (72.52%)

7.14 hits per line