vispy / vispy / 15131877268

75%

Build Type

push

github

Committed by web-flow

Commit Message

Only use last 2 event dimensions for arcball calculation (#2677)

When using arcball camera and pressing shift to switch from rotating
panning, if shift is released before the drag is finished, one receives
this traceback:


```py
Traceback (most recent call last):
  File ".../lib/site-packages/vispy/util/event.py", line 469, in _invoke_callback
    cb(event)
  File ".../lib/site-packages/napari/_vispy/camera.py", line 244, in viewbox_mouse_event
<class 'TypeError'> SceneMouseEvent type 'mouse_move' has no scale <traceback object at 0x000002867B3AFE00>
    super().viewbox_mouse_event(event)
  File ".../lib/site-packages/vispy/scene/cameras/perspective.py", line 233, in viewbox_mouse_event
    self._update_rotation(event)
  File ".../lib/site-packages/vispy/scene/cameras/arcball.py", line 65, in _update_rotation
    Quaternion(*_arcball(self._event_value, wh)) *
  File ".../lib/site-packages/vispy/scene/cameras/arcball.py", line 101, in _arcball
    x, y = xy
ValueError: too many values to unpack (expected 2)

[...]
```


This is because in that specific moment, the event received will have a
3dimensional position instead of a 2D canvas position. I simply copied
how the `p2` wa taking the last 2 dims, and everything works fine.


Related issues:

-
https://forum.image.sc/t/sometimes-the-3d-viewer-of-napari-crashes-when-moving-the-center-of-the-camera/112571
- https://github.com/napari/napari/issues/6806

Run Details

5871 of 10619 branches covered (55.29%)

0 of 1 new or added line in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

24188 of 32295 relevant lines covered (74.9%)

2.45 hits per line