xapi-project
/
xen-api
/
15117587391
78%
master: 80%
master: 80%
|
Ran
|
Jobs
1
|
Files
33
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 77.719%. Remained the same
push
github
web-flowCA-411122: do not call set-iscsi-initiator with an empty string for IQN (#6474) Back in 2018 a4a94b38c rejected empty IQNs in set_iscsi_iqn API calls. However hosts are created with an empty IQN, and if this code runs too early then it will attempt to call `set-iscsi-initiator` with an empty string for the IQN: ``` /opt/xensource/libexec/set-iscsi-initiator myhost ``` About a second later the script is called again with the correct value. This could potentially result in the iscsid service being restarted multiple times (and if a restart is still pending when restart is called a 2nd time I'm not sure it'll take effect, so we might be left with an empty initiator, I have also seen a GFS2 SR plug failure following this). It is best to avoid setting empty initiators. The exception would be raised and ignore due to the log_and_ignore in the caller. Also log wherever the IQN is set using %S, so that we notice if it ends up containing some extra whitespace characters.
3359 of 4322 relevant lines covered (77.72%)
0.78 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | python3.11 - 15117587391.1 | 33 |
77.72 |
GitHub Action Run |
