rust-bitcoin / rust-bitcoin / 15087903754

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4521: feat(p2p): add `AddrV2` <> `SocketAddr` conversions

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/a1d4bc31e5c7cfe0227db64aec8671efcc0c6677">a1d4bc31e<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/e541221950add271c1308ce04565643eb16151cf"> test(p2p): add tests for `AddrV2` <> `SocketAddr` conversions (Luis Schwab)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/64387f566e05ee88491121fbe9e44e6fcfbc38e4">64387f566</a> feat(p2p): add `AddrV2` <> `SocketAddr` conversions (Luis Schwab)

Pull request description:

  Closes #4436.

  Note: I made the `AddrV2::Cjdns` to `SocketAddr` conversion throw the `CjdnsNotRecommended` error. Do we want this behavior or just assume the user knows what he is doing? cc Kixunil

  ### Changelog
  - Implement `From<SocketAddr> for AddrV2`.
  - Implement `TryFrom<AddrV2> for SocketAddr`.
  - Implement `AddrV2ConversionError` enum and it's `fmt::Display`.
  - Tests for these conversions.

ACKs for top commit:
  apoelstra:
    ACK a1d4bc31e5c7cfe0227db64aec8671efcc0c6677; successfully ran local tests
  tcharding:
    ACK a1d4bc31e5c7cfe0227db64aec8671efcc0c6677

Tree-SHA512: c11f30534cba0555866be4a739fa7018105

Coverage Stats

96 of 103 new or added lines in 1 file covered. (93.2%)

1 existing line in 1 file now uncovered.

23429 of 27680 relevant lines covered (84.64%)

16069.77 hits per line