Qiskit / qiskit / 15072432645

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Add ParameterExpression in Rust (#13278)

* Add SymbolicExExpression in Rust

This PR is a new implementation of ParameterExpression written in Rust for issue #13267

This PR implements our own symbolic expression library written in Rust, this replaces
symengine from ParameterExpression class.

`crates/circuit/symbol_expr.rs` is a symbolic expression module. Equations with symbols
and values are expressed by using AST structure with nodes of operations. This module
contains all the operators defined in Python's ParameterExpression class.

To separate Rust's implementation from Python we prepared Python interface class
`crates/circuit/symbol_expr_py.rs` that is called from ParameterExpression in Python,
instead of symengine.

`crates/circuit/parameterexpression.rs` is the ParameterExpression class for Rust.
It provides similar functionalities to Python version.

* Remove unused parameterexpression.rs file

This file is more future facing and doesn't have any current uses. To
simplify the PR to just the working component this commit removes the
file. We can add it back in the future when there is use case for the
module.

* Change py suffix to prefix

This commit just renames the symbol_expr_py file and module to
py_symbol_expr. We typically use a Py prefix when describing objects
that are just for python. This change was just done to make this new
module match that expectation.

* Fix qiskit-circuit cargo dependencies

The Cargo.toml for qiskit-circuit was missing some details to use the
approx crate correctly with Complex64 types and arrays of those types.
This didn't bubble up in combined builds because cargo was reusing the
compilation unit for these crates with accelerate which had the correct
settings. But when trying to do a standalone build of qiskit-circuit
this caused a compilation error. This commit fixes this by updating the
local dependencies to ensure the appropriate features to use approx with
complex and ndarray are set.

* Use unix styl... (continued)

Run Details

2152 of 2811 new or added lines in 9 files covered. (76.56%)

9 existing lines in 3 files now uncovered.

78446 of 88841 relevant lines covered (88.3%)

427968.76 hits per line