dart-lang / native / 15063664918

82%

push

github

[hooks_runner] Optimize the no hooks path (#2302)

Bug: https://github.com/dart-lang/native/issues/2236

Optimize the code paths for when there are no hooks (speeds up standalone Dart).

* Return early in various places, and check if there are hooks at all as first thing.
* Write JSON encoding instead of YAML encoding. 17 ms -> 1 ms on a small JSON object. (And JSON is valid YAML.)

After this the longest running part in `dartdev` is loading the `package_config.json`: 10 ms. We can't really avoid this because we need that info to check whether we have any hooks that need running. And the `package_config.json` isn't already loaded by dartdev (in contrast to `flutter_tools` where we have a `PackageConfig` object available). dartdev delegates compilation to `package:pub`(!) via `getExecutableForCommand` and that API uses the package config file path. https://github.com/dart-lang/pub/issues/4067

9 of 9 new or added lines in 3 files covered. (100.0%)

8852 of 10580 relevant lines covered (83.67%)

40.9 hits per line