• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

spesmilo / electrum / 4829117322887168
71%

Build:
DEFAULT BRANCH: master
Ran 15 May 2025 07:45PM UTC
Jobs 5
Files 87
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

15 May 2025 07:35PM UTC coverage: 59.726% (+0.002%) from 59.724%
4829117322887168

push

CirrusCI

SomberNight
synchronizer: get_transaction should discard tx_height as it can change

tx_height comes from the `get_history` RPC, we then call the `get_transaction` RPC.
By the time the `get_transaction` RPC returns, we might have received another
scripthash status update, called `get_history` again, and updated height for the txid.
Synchronizer._get_transaction() should not call adb.receive_tx_callback() with
the old tx_height (but it was doing exactly that).

Patch to trigger, e.g. regtest failures:
(e.g. for tests.regtest.TestLightningAB.test_extract_preimage)
```
diff --git a/electrum/interface.py b/electrum/interface.py
index 8649652b9c..fce7a1c6de 100644
--- a/electrum/interface.py
+++ b/electrum/interface.py
@@ -991,6 +991,7 @@ class Interface(Logger):
         return res

     async def get_transaction(self, tx_hash: str, *, timeout=None) -> str:
+        await asyncio.sleep(3)
         if not is_hash256_str(tx_hash):
             raise Exception(f"{repr(tx_hash)} is not a txid")
         raw = await self.session.send_request('blockchain.transaction.get', [tx_hash], timeout=timeout)

```

6 of 12 new or added lines in 2 files covered. (50.0%)

3 existing lines in 3 files now uncovered.

21549 of 36080 relevant lines covered (59.73%)

2.98 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4829117322887168.1 15 May 2025 07:45PM UTC 0
59.69
2 4829117322887168.2 15 May 2025 07:45PM UTC 0
59.69
3 4829117322887168.3 15 May 2025 07:45PM UTC 0
59.7
4 4829117322887168.4 15 May 2025 07:46PM UTC 0
59.68
5 4829117322887168.5 15 May 2025 08:05PM UTC 0
59.68
Source Files on build 4829117322887168
Detailed source file information is not available for this build.
  • Back to Repo
  • Build #48291173...
  • b1f0c6e3 on github
  • Prev Build on master (#64016717...)
  • Next Build on master (#50748513...)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc