babelfish-for-postgresql / babelfish_extensions / 15040063395

77%

Build Type

push

github

Committed by web-flow

Commit Message

Reimplement ISNUMERIC() function in C language to improve performance (#3739)

To improve the performance of queries with ISNUMERIC() predicates, this commit
reimplements the ISNUMERIC() function from PL/pgSQL to C language. The new implementation
uses InputFunctionCallSafe for safer and more efficient type checking and conversion.

Additionally, the money data type's input function has been updated to report
invalid input as a "soft" error for InputFunctionCallSafe, avoiding unnecessary transaction aborts.
This commit also changes the ISNUMERIC() function attributes to IMMUTABLE and
PARALLEL SAFE for better query optimisation opportunities.

Task : BABEL-5696
Signed-off-by: Sumit Jaiswal <sumiji@amazon.com>

Run Details

56 of 61 new or added lines in 2 files covered. (91.8%)

6 existing lines in 2 files now uncovered.

48551 of 64440 relevant lines covered (75.34%)

297509.8 hits per line