skeema / skeema / 15031519745

92%

push

github

MariaDB: support role-based DEFINERs for stored objects

User roles are represented differently in MySQL vs MariaDB. In MySQL, they are
internally formatted like user names (user@host), although the host portion is
almost always "%" and is optional in hand-written SQL. Meanwhile in MariaDB,
the host portion is always omitted entirely; roles are essentially just bare
usernames with the @host portion.

This affects DEFINER clauses of stored programs, when using a role as the
DEFINER. Previously, Skeema was unable to operate on any MariaDB schema
using roles as DEFINERs. This commit fixes handling of such stored programs
across all commands.

This commit also improves lint-definer to allow role name patterns to be
listed in allow-definer. The default permissive allow-definer of %@%
intentionally now permits role-based definers, but otherwise allowed role
definers should be configured without the @ symbol or hostname portion.

101 of 103 new or added lines in 4 files covered. (98.06%)

10435 of 11199 relevant lines covered (93.18%)

1.11 hits per line