rust-bitcoin / rust-bitcoin / 15025757677

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4506: units: Manually implement serde traits

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/e2d03fef72f4fcbdacd1cbecc0c2dddfbdeb3031">e2d03fef7 units: Manually implement serde traits (Tobin C. Harding)

Pull request description:

  For types that have private inner fields we would like to manually implement `serde` traits instead of deriving them.

  This hardens the crate against making future mistakes if we want to change the inner fields.

  Do so for:

  - `Weight`
  - `BlockTime`
  - `NumberOfBlocks`
  - `NumberOf512seconds`

ACKs for top commit:
  apoelstra:
    ACK e2d03fef72f4fcbdacd1cbecc0c2dddfbdeb3031; successfully ran local tests

Tree-SHA512: 6d3cc4106d1c0b2f6f713810a5fcd075e3d

36 of 48 new or added lines in 3 files covered. (75.0%)

23300 of 27540 relevant lines covered (84.6%)

16011.33 hits per line