rust-bitcoin / rust-bitcoin / 14976826633

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4472: Change the return type of effective_value

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/b038520c4dc8c2f92cb40a9fd272608ae2e9b799">b038520c4 Change the return type of effective_value (yancy)

Pull request description:

  Prefer the more informative return type NumOpResult over Option.  Also a returns section was added which describes the different possible returns.

  The api of NumOpResult could probably be extended to cleanup the match statement.  Also consider api addition for unchecked calculations natively.

ACKs for top commit:
  tcharding:
    ACK b038520c4dc8c2f92cb40a9fd272608ae2e9b799
  apoelstra:
    ACK b038520c4dc8c2f92cb40a9fd272608ae2e9b799; successfully ran local tests

Tree-SHA512: 2e66a3ca83dc030e7cb6970b428fee3c61c

Coverage Stats

6 of 6 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

23152 of 27409 relevant lines covered (84.47%)

16154.34 hits per line