babelfish-for-postgresql / babelfish_extensions / 14972467354

77%

Build Type

push

github

Committed by web-flow

Commit Message

TDS sender support and Custom query parser for POINT ZM flags (#3612)

TDS sender support and Custom query parser for POINT ZM flags

This PR introduces comprehensive improvements to spatial data type handling in Babelfish. It covers syntax parsing, TDS transmission, function support, and CAST operations.
Key Enhancements:

    Syntax Support - NULL Handling:
        Added parser support with lexer definitions, parsing tree, support functions, and structured error handling.
        Rewrote Point struct for better maintainability.

    TDS Sender Enhancements:
        Investigated and implemented structured handling of empty points, 2D/3D/M points, and general spatial data transmission.

    Function Support Improvements:
        Migrated SQL-based logic to C for better performance.
        Enhanced SRID validation and rewrote geography/geometry logic to remove redundant type checks.
        Implemented STAsBinary and STDistance function improvements, including handling for empty geometries and ensuring correct SRID validation.

    CAST Support for Spatial Data:
        Improved conversion between character, byte, geography, and geometry types.
        Investigated flag behaviors and ensured proper handling of empty spatial objects.

    Comprehensive Testing:
        Verified function correctness across empty geometries, different dimensions, and NULL combinations.
        Added CAST tests for all formats to ensure seamless conversions.

Issues Resolved

Tasks:

    BABEL-5671
    BABEL-5769
    BABEL-5770

Signed-off by: Mohit Raj mrxmohit@amazon.com

Run Details

588 of 614 new or added lines in 5 files covered. (95.77%)

9 existing lines in 2 files now uncovered.

48513 of 64395 relevant lines covered (75.34%)

297234.08 hits per line