4719930714619904
60%
master: 63%

Ran 09 May 2025 06:25PM UTC

Jobs 5

Files 87

Run time 1min

Badge

Embed ▾

Committed 09 May 2025 06:03PM UTC coverage: 59.712% (-0.003%) from 59.715%

Build # 4719930714619904

Build Type

Pull #9801

CirrusCI

Committed by

SomberNight

Commit Message

ci: add linter task "ban unicode" to protect against malicious unicode

This script scans the whole codebase for unicode characters and
errors if it finds any, unless the character is specifically whitelisted.

The motivation is to protect against homoglyph attacks, invisible unicode characters,
bidirectional and other control characters, and other malicious unicode usage.

Given that we mostly expect to use ASCII characters in the source code,
the most robust and generic fix seems to be to just ban all unicode usage.

see https://trojansource.codes/ :
> Compilers, interpreters, and build pipelines supporting Unicode should throw errors or warnings
> for unterminated bidirectional control characters in comments or string literals,
> and for identifiers with mixed-script confusable characters.
> Language specifications should formally disallow unterminated bidirectional
> control characters in comments and string literals.
> Code editors and repository frontends should make bidirectional control characters
> and mixed-script confusable characters perceptible with visual symbols or warnings.

also https://github.com/maltfield/detect-malicious-unicode

Pull Request Pull Request #9801: ci: add linter task "ban unicode" to protect against malicious unicode

Run Details

21522 of 36043 relevant lines covered (59.71%)

2.98 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	65.6	-0.09%	electrum/lnchannel.py
1	58.14	-0.05%	electrum/lnpeer.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	4719930714619904.1	09 May 2025 06:25PM UTC	87	59.68
2	4719930714619904.2	09 May 2025 06:25PM UTC	87	59.68
3	4719930714619904.3	09 May 2025 06:25PM UTC	87	59.68
4	4719930714619904.4	09 May 2025 06:25PM UTC	87	59.69
5	4719930714619904.5	09 May 2025 06:45PM UTC	87	59.68

spesmilo / electrum / 4719930714619904
60%
master: 63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 4719930714619904

spesmilo / electrum / 4719930714619904 60% master: 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 4719930714619904

spesmilo / electrum / 4719930714619904
60%
master: 63%

README BADGES
x