openwisp
/
openwisp-controller
/
14911541476
99%
master: 99%
master: 99%
|
Ran
|
Jobs
1
|
Files
119
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 98.901%. First build
push
github
nemesifier[fix] Fixed live updates for "Send commands" Bug: When multiple connections are made to the websocket command endpoint of the same device (e.g. when multiple browser tabs are open for the same device), the UI does not receive updates from the websocket and keeps showing a loader in the command output field, even when the command has completed execution. Fix: The issue was caused by mutating the shared `event` dictionary in the `send_update` method of `CommandConsumer`. Specifically, calling `event.pop('type')` removed the `'type'` key from the event. Since the same event object is dispatched to all consumer instances (one for each websocket connection), removing `'type'` in one instance caused the others to raise: ValueError: Incoming message has no 'type' attribute This broke message dispatch for the remaining connections. The fix is to avoid modifying the original `event` dictionary. This preserves the `'type'` key, ensuring all consumer instances continue to receive well-formed events and function correctly. (cherry picked from commit 35dbfe5bb)
6297 of 6367 relevant lines covered (98.9%)
8.9 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | python- - 14911541476.1 | 119 |
98.9 |
GitHub Action Run |
