rust-bitcoin / rust-bitcoin / 14910567652

83%

master: 83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4443: backport: Add XOnlyPublicKey support for PSBT key retrieval and improve Taproot signing

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/95eb2556b93da25a402e82eab1e032a0ececb67e">95eb2556b<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2044697c28d5a627cba10c37d101abfc15a02635"> Add XOnlyPublicKey support for PSBT key retrieval and improve Taproot signing (Erick Cestari)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2858b6cf801def1800a2cfd3287a38633d194a49">2858b6cf8</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2044697c28d5a627cba10c37d101abfc15a02635"> Support GetKey where the Xpriv is a direct child of the looked up KeySource (Nadav Ivgi)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d005ddd5249909bd8919a169abb5c7d6d2386ec1">d005ddd52</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2044697c28d5a627cba10c37d101abfc15a02635"> Refactor GetKey for sets to internally use Xpriv::get_key() (Nadav Ivgi)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b75b2e36496674d2dd9964c726dbdd50b3d1ed01">b75b2e364</a> Fix GetKey for sets to properly compare the fingerprint (Nadav Ivgi)

Pull request description:

  Backport two PRs:

  - #3356
  - #4238

  The first includes a bug fix in a `GetKey` impl and the second is a feature we want to release. And the three refactor patches touch code that #4238 builds on so I figured we should backport them all.

  All 5 patches required a small amount of massaging to get in. The first 4 was just adding a `?` to the calls to `derive_priv`. The last patch needed a few calls in the unit test changing.

ACKs for top commit:
  storopoli:
    ACK 95eb2556b93da25a402e82eab1e032a0ececb67e
  apoelstra:
    ACK 95eb2556b93da25a402e82eab1e032a0ececb67e; successfully ran local tests

Tree-SHA512: 5b73c4cd3704dba8d9ab9e2d15d05d899c5

Run Details

111 of 146 new or added lines in 2 files covered. (76.03%)

1 existing line in 1 file now uncovered.

18862 of 22519 relevant lines covered (83.76%)

17255.26 hits per line