multipath-tcp / mptcpd / 14903550590
67%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 17
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 68.972%. Remained the same
14903550590

push

github

web-flow 
musl compat (#314)

* include: use __swab i/o __bswap_constant

Some C standard libs like musl don't support __bswap_constant_{16,32}.

Importing the "simple" macros could be enough, but they are under LGPL.
Using __swab from linux/swab.h seems easier.

Suggested-by: Ossama Othman <ossama.othman@gmail.com>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

* mptcpize: define error() if not available

Some libc like musl don't support it.

It is easy enough to define a simple version for our need.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

* config: special case for default logger

The current version taking an unlimited number of args, and with
multiple levels of helpers doesn't seem to be supported on some embedded
environments, e.g. Alpine Linux:

  configuration.c: In function 'mptcpd_config_create':
  configuration.c:54:47: error: pasting "l_log_set_" and "(" does not give a valid preprocessing token
     54 | #define MPTCPD_SET_LOG_FUNCTION MPTCPD_CONCAT(l_log_set_, MPTCPD_LOGGER)
        |                                               ^~~~~~~~~~
  configuration.c:42:36: note: in definition of macro 'MPTCPD_CONCAT_IMPL'
     42 | #define MPTCPD_CONCAT_IMPL(x, ...) x ## __VA_ARGS__
        |                                    ^
  configuration.c:54:33: note: in expansion of macro 'MPTCPD_CONCAT'
     54 | #define MPTCPD_SET_LOG_FUNCTION MPTCPD_CONCAT(l_log_set_, MPTCPD_LOGGER)
        |                                 ^~~~~~~~~~~~~
  configuration.c:802:9: note: in expansion of macro 'MPTCPD_SET_LOG_FUNCTION'
    802 |         MPTCPD_SET_LOG_FUNCTION();  // For early logging.
        |         ^~~~~~~~~~~~~~~~~~~~~~~
  configuration.c:54:47: error: implicit declaration of function 'l_log_set_'; did you mean 'l_log_set_null'? [-Werror=implicit-function-declaration]
     54 | #define MPTCPD_SET_LOG_FUNCTION MPTCPD_CONCAT(l_log_set_, MPTCPD_LOGGER)
        |                                               ^~~~~~~~~~
  configu... (continued)

1516 of 2198 relevant lines covered (68.97%)

16.6 hits per line

Jobs
ID Job ID Ran Files Coverage
1 14903550590.1 34
66.52
 GitHub Action Run
Source Files on build 14903550590