rust-bitcoin / rust-bitcoin / 14894512875

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4458: locktimes: replace `MtpAndHeight` type with pair of `BlockMtp` and `BlockHeight`

47c77afaa units: delete MtpAndHeight type (Andrew Poelstra)
d82b8c0bc primitives: stop using MtpAndHeight (Andrew Poelstra)
72d5fbad7 units: stop using MtpAndHeight in locktime::relative is_satisfied_by methods (Andrew Poelstra)
d933c754f units: change type of MtpHeight::to_mtp to BlockMtp (Andrew Poelstra)
dcbdb7ca8 units: add checked arithmetic to Block{Height,Mtp}{Interval,} (Andrew Poelstra)
4300271f0 units: add constructor for absolute::Mtp from timestamps (Andrew Poelstra)
4e4601b3d units: rename BlockInterval to BlockHeightInterval (Andrew Poelstra)
cb882c5ce units: add global `BlockMtpInterval` type (Andrew Poelstra)
4e3af5162 units: add global `BlockMtp` type (Andrew Poelstra)
a3228d463 units: pull u32 conversions for BlockHeight/BlockInterval into macro (Andrew Poelstra)

Pull request description:

  This is a more involved PR than I'd expected but hopefully the individual commits make sense and are well-motivated. Essentially, my goal was to replace `MtpAndHeight` as used by relative locktimes with a pair of `Mtp` and `Height`.

  However, relative locktimes, when given a MTP/Height for the UTXO creation and the chain tip, are roughly modeled as "take a diff of MTPs to get a `relative::MtpInterval`, a diff of heights to get a `relative::HeightInterval`, and compare to the locktimes". *However*, we have no standalone MTP type to "take a diff of", and also there are failure modes when creating the diffs (e.g. if the diff would exceed the range of `MtpInterval` or `HeightInterval`).

  So I backed up and decided to use th... (continued)

Coverage Stats

152 of 189 new or added lines in 4 files covered. (80.42%)

5 existing lines in 2 files now uncovered.

23065 of 27391 relevant lines covered (84.21%)

16186.11 hits per line