rust-bitcoin / rust-bitcoin / 14889043156
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 131
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.245% (-0.002%) from 84.247%
14889043156

push

github

apoelstra 
Merge rust-bitcoin/rust-bitcoin#4410: Wrap secp256k1::XOnlyPublicKey to improve error handling

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/c11772a768eefd89dcc0e3b1a369d535c191f94a">c11772a76<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/7d4b40dfd4b70bb3e28003db924a3d2d608395d6"> Accept flexible input types for Taproot-related functions (Erick Cestari)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2a518d62e6e310d2242dbbbe7176f1ea75759e43">2a518d62e</a> Wrap secp256k1::XOnlyPublicKey to improve error handling (Erick Cestari)

Pull request description:

  This PR addresses issue #4361 by creating a wrapper type for XOnlyPublicKey instead of directly re-exporting it from the secp256k1 library.

  ### Key Changes

  1. Created a new `XOnlyPublicKey` struct that wraps `secp256k1::XOnlyPublicKey`
  2. Implemented custom error types:
      - `ParseXOnlyPublicKeyError` for handling parsing errors
      - `TweakXOnlyPublicKeyError` for tweaking an `XOnlyPublicKey`
  3. Updated all imports and usage throughout the codebase
  4. Implemented necessary traits and methods for compatibility

  Closes #4361

ACKs for top commit:
  apoelstra:
    ACK c11772a768eefd89dcc0e3b1a369d535c191f94a; successfully ran local tests
  tcharding:
    ACK c11772a768eefd89dcc0e3b1a369d535c191f94a

Tree-SHA512: c8da3486eef2bd720e3d217fa78f5893965

65 of 86 new or added lines in 6 files covered. (75.58%)

23019 of 27324 relevant lines covered (84.24%)

16174.75 hits per line

Uncovered Changes

Lines Coverage ∆ File
20
67.77
 0.3% bitcoin/src/crypto/key.rs
1
90.82
 -0.85% bitcoin/src/address/script_pubkey.rs
Jobs
ID Job ID Ran Files Coverage
1 14889043156.1 131
84.24
 GitHub Action Run
Source Files on build 14889043156